Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-radio): add accessible touch targets #22994

Merged
merged 1 commit into from Jun 22, 2021
Merged

fix(material-experimental/mdc-radio): add accessible touch targets #22994

merged 1 commit into from Jun 22, 2021

Conversation

crisbeto
Copy link
Member

Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in #22892.

Fixes #22991.

@crisbeto
fix(material-experimental/mdc-radio): add accessible touch targets
71ffaef 
Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in angular#22892.

Fixes angular#22991.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jun 16, 2021
@crisbeto crisbeto requested a review from jelbourn June 16, 2021 15:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 16, 2021
jelbourn
jelbourn approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jun 16, 2021
@Asiabi

This comment has been minimized.

Sign in to view
@jelbourn jelbourn added this to Failing presubmit in Accessibility 2021 Jun 21, 2021
@jelbourn jelbourn removed this from Failing presubmit in Accessibility 2021 Jun 21, 2021
@mmalerba mmalerba merged commit 150d5af into angular:master Jun 22, 2021
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
@crisbeto @mmalerba
fix(material-experimental/mdc-radio): add accessible touch targets (#…
6074fd1 
…22994)

Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in #22892.

Fixes #22991.

(cherry picked from commit 150d5af)
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
@crisbeto @mmalerba
fix(material-experimental/mdc-radio): add accessible touch targets (#…
041f582 
…22994)

Sets up accessible touch targets on the MDC-based radio button.

Also hides the touch targets on the two lowest densities. This is something I forgot to do in #22892.

Fixes #22991.

(cherry picked from commit 150d5af)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba left review comments

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MDC-based checkbox & radio click targets are too small
4 participants
@crisbeto @Asiabi @jelbourn @mmalerba