Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(Datepicker): The calendarLabel property is not read by the screen reader, and is not assigned in the DOM #27935

Open
1 task
lidiagabriela opened this issue Oct 12, 2023 · 0 comments · May be fixed by #28652
Open
1 task

bug(Datepicker): The calendarLabel property is not read by the screen reader, and is not assigned in the DOM #27935

lidiagabriela opened this issue Oct 12, 2023 · 0 comments · May be fixed by #28652
Assignees
@zarend
Labels
Accessibility This issue is related to accessibility (a11y) area: material/datepicker P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@lidiagabriela
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

The calendarLabel property is not read by the screen reader and is not assigned in the DOM.
I also searched in the source code of the calendar component and it seems that it exists only in the documentation, and in the html or ts code it is not assigned anywhere.

Reproduction

StackBlitz link: https://stackblitz.com/edit/lhj2eb?file=src%2Fapp%2Fmy-date-picker-intl.service.ts
Steps to reproduce:

  1. Open stackblitz example
  2. Open NVDA screen reader (or other screen reader)
  3. Focus the datepicker icon
  4. Press 'enter' key to open the calendar popup

Expected Behavior

The calendarLabel property should be read by the screen reader and should exist in the DOM.

Actual Behavior

The calendarLabel property is not read by the screen reader and is not assigned in the DOM.

Environment

  • Angular: v15.0.4/v15.2.9
  • CDK/Material: v15.2.9
  • Browser(s): doesn't matter (I tested on Microsoft Edge version 117.0.2045.60)
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows 10 Enterprise v21H2
@lidiagabriela lidiagabriela added the needs triage This issue needs to be triaged by the team label Oct 12, 2023
@andrewseguin andrewseguin added area: cdk/a11y Accessibility This issue is related to accessibility (a11y) area: material/datepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed area: cdk/a11y needs triage This issue needs to be triaged by the team labels Oct 12, 2023
@zarend zarend added P5 The team acknowledges the request but does not plan to address it, it remains open for discussion and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Feb 26, 2024
zarend added a commit to zarend/components that referenced this issue Feb 26, 2024
@zarend
fix(material/datepicker): remove unused calendarLabel
e31bb50 
Removed unused property `MatDatepickerIntl:calendarLabel`.

Remove dead code. Does not make behavior or visual change.

Fix angular#27935
@zarend zarend linked a pull request Feb 26, 2024 that will close this issue
Open
zarend added a commit to zarend/components that referenced this issue Feb 26, 2024
@zarend
fix(material/datepicker): deprecate calendarLabel
0821f27 
Deprecate `MatDatepickerIntl:calendarLabel`. calendarLabel is not used.

Deprecate dead code. Does not change behavior.

Resolve angular#27935
@zarend zarend self-assigned this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zarend zarend

Labels
Accessibility This issue is related to accessibility (a11y) area: material/datepicker P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/datepicker): deprecate calendarLabel zarend/components
3 participants
@zarend @andrewseguin @lidiagabriela