Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): deprecate calendarLabel #28652

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Feb 26, 2024

Removed unused property MatDatepickerIntl:calendarLabel.

Remove dead code. Does not make behavior or visual change.

Fix #27935

@zarend zarend added target: major This PR is targeted for the next major release area: material/datepicker labels Feb 26, 2024
Deprecate `MatDatepickerIntl:calendarLabel`. calendarLabel is not used.

Deprecate dead code. Does not change behavior.

Resolve angular#27935
@zarend zarend changed the title fix(material/datepicker): remove unused calendarLabel fix(material/datepicker): deprecate calendarLabel Feb 26, 2024
@zarend zarend marked this pull request as ready for review February 26, 2024 23:22
@zarend zarend removed the request for review from mmalerba March 11, 2024 17:13
@zarend zarend added action: merge The PR is ready for merge by the caretaker detected: breaking change PR contains a commit with a breaking change and removed detected: breaking change PR contains a commit with a breaking change labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/datepicker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Datepicker): The calendarLabel property is not read by the screen reader, and is not assigned in the DOM
2 participants