refactor: remove abstract directive selector workaround #17476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
refactor/remove-abstract-directive-workaround
branch
3 times, most recently
from
bf0cf31
to
ec6253c
Compare
|
Removing this workaround unveiled two issues:
|
devversion
added
the
blocked
|
I think both of these things could be considered blockers for v9. So it might be worth prioritizing them in framework. cc. @jelbourn |
devversion
force-pushed
the
refactor/remove-abstract-directive-workaround
branch
from
ec6253c
to
540be42
Compare
devversion
added
target: patch
devversion
requested review from
andrewseguin,
crisbeto and
mmalerba
as code owners
devversion
force-pushed
the
refactor/remove-abstract-directive-workaround
branch
from
540be42
to
df88799
Compare
crisbeto
approved these changes
Nov 6, 2019
Since we updated the minimum required Angular version, and updated to Angular v9.0.0-0, we can remove the workaround for abstract directives. Previously we wanted to keep them with a selector regardless of the installed version, because we thought that we want to support ^8.0.0 of Angular.
devversion
force-pushed
the
refactor/remove-abstract-directive-workaround
branch
from
df88799
to
db0d8b1
Compare
crisbeto
reviewed
Nov 6, 2019
| }) : | ||
| null; | ||
| const selectorText = | ||
| selectorProp != null && ts.isStringLiteralLike(selectorProp.initializer) ? |
There was a problem hiding this comment.
We probably don't need to look at the selector's text, just that the property is defined. I think the compiler will throw if the selector is invalid as well.
There was a problem hiding this comment.
One could still set the selector to undefined, so I thought I'll cover that.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we updated the minimum required Angular version, and
updated to Angular
^9.0.0-0, we can remove the workaroundfor abstract directives. Previously we wanted to keep them
with a selector regardless of the installed version, because
we thought that we want to support
^8.0.0of Angular.