Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expand input types with coercion to work with ngtsc input type checking #17528

Merged
merged 5 commits into from
Oct 31, 2019
Merged

feat: expand input types with coercion to work with ngtsc input type checking #17528

merged 5 commits into from
Oct 31, 2019

Commits on Oct 31, 2019

  1. feat: expand input types with coercion to work with ngtsc input type … 

    …checking
    @jelbourn @devversion
    jelbourn authored and devversion committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    fc51dcc View commit details
    Browse the repository at this point in the history

  2. refactor: add workaround for strict metadata emit of coercion static … 

    …members

See: angular/angular#33451
    @devversion
    devversion committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    35430ff View commit details
    Browse the repository at this point in the history

  3. build: patch ng_module bazel rule to enable strict template type chec… 

    …king

Workaround for: angular/angular#33452
    @devversion
    devversion committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    2ab27c6 View commit details
    Browse the repository at this point in the history

  4. refactor: disable strict metadata emit for legacy build output 

    Workaround for angular/angular#33451. This makes
sense at the current time since the Bazel output does *never* work with
strict metadata emit... and considering that with Ivy there is no metadata
anyway, it could be disabled in the meanwhile.
    @devversion
    devversion committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    920102a View commit details
    Browse the repository at this point in the history

  5. build: disable strict attribute type checking 

    We are temporarily disabling strict attribute type checking
since we have a few templates that set a coerced input while
the `NgModel` directive is applied. In those cases, the empty string
for the `disabled` input, is not assignable to the `NgModel#disabled` input,
since it does not do coercion. We need to figure out what to do in those
scenarios.
    @devversion
    devversion committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    d9d5683 View commit details
    Browse the repository at this point in the history