build: enable coercion-types rule and fix leftover cases #17609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
jelbourn and
a team
as code owners
googlebot
added
the
cla: yes
devversion
approved these changes
Nov 4, 2019
crisbeto
force-pushed
the
enable-coercion-rule
branch
from
f41cdfd
to
1ce6b3b
Compare
|
I did it for the stepper example, because it shows how to extend a stepper so anybody doing it will have to do it as well. I reworked the rest since they are either internal or didn't have to coerce in the first place. |
crisbeto
force-pushed
the
enable-coercion-rule
branch
from
1ce6b3b
to
a6c6f5a
Compare
devversion
approved these changes
Nov 4, 2019
...mples/cdk/stepper/cdk-custom-stepper-without-form/cdk-custom-stepper-without-form-example.ts
Show resolved
Hide resolved
Follow-up from angular#17528 that: * Turns on the `coercion-types` rule. * Fixes the rule not detecting abstract directives properly. * Fixes the rule incorrectly flagging coercion functions used inside of callbacks which are inside of setters. * Either fixes or works around a final set of failures.
crisbeto
force-pushed
the
enable-coercion-rule
branch
from
a6c6f5a
to
ede078b
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #17528 that:
coercion-typesrule.