-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: allow ng_package patch to silently fail so that issue can be fixed in angular repo #17620
build: allow ng_package patch to silently fail so that issue can be fixed in angular repo #17620
Conversation
…ixed in angular repo angular/angular#32603 will be fixed in angular/angular#33607 but the fix breaks this patch which breaks the material-unit-test job on that PR (https://app.circleci.com/jobs/github/angular/angular/515946). This change is temporary so that #33607 can land in angular.
Temporary commit. DO NOT MERGE UPSTREAM.
Temporary commit. DO NOT MERGE UPSTREAM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I assume since we now no longer use the internal/rollup
but rather the package/rollup
, we need to manually bring in the needed rollup plugin dependencies? Can you confirm?
Should these be actually brought in by @angular/bazel
?
Yes, these npm deps need to brought in now as they are peerDeps of @angular/bazel and no longer direct deps. We've moved a peerDeps pattern for all of the nodejs rules as it makes more sense for the node ecosystem. Don't merge this yet, I have one last failure on angular/angular#33607 material-unit-tests to resolve: https://app.circleci.com/jobs/github/angular/angular/516209. |
Temporary commit. DO NOT MERGE UPSTREAM.
@gregmagolan I see. Thanks for the explanation. Makes sense that they are listed as peer dependencies in |
Temporary commit. DO NOT MERGE UPSTREAM.
Ok. All green on the angular repo tested with this branch: https://app.circleci.com/jobs/github/angular/angular/516838 Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
angular/angular#32603 will be fixed in angular/angular#33607 but the fix breaks this patch which breaks the material-unit-test job on that PR (https://app.circleci.com/jobs/github/angular/angular/515946). This change is temporary so that #33607 can land in angular.