Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow ng_package patch to silently fail so that issue can be fixed in angular repo #17620

Merged
merged 2 commits into from
Nov 6, 2019

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Nov 6, 2019

angular/angular#32603 will be fixed in angular/angular#33607 but the fix breaks this patch which breaks the material-unit-test job on that PR (https://app.circleci.com/jobs/github/angular/angular/515946). This change is temporary so that #33607 can land in angular.

…ixed in angular repo

angular/angular#32603 will be fixed in angular/angular#33607 but the fix breaks this patch which breaks the material-unit-test job on that PR (https://app.circleci.com/jobs/github/angular/angular/515946). This change is temporary so that #33607 can land in angular.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 6, 2019
@gregmagolan gregmagolan marked this pull request as ready for review November 6, 2019 01:02
@gregmagolan gregmagolan requested a review from a team as a code owner November 6, 2019 01:02
gregmagolan added a commit to gregmagolan/angular that referenced this pull request Nov 6, 2019
Temporary commit. DO NOT MERGE UPSTREAM.
gregmagolan added a commit to gregmagolan/angular that referenced this pull request Nov 6, 2019
Temporary commit. DO NOT MERGE UPSTREAM.
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume since we now no longer use the internal/rollup but rather the package/rollup, we need to manually bring in the needed rollup plugin dependencies? Can you confirm?

Should these be actually brought in by @angular/bazel?

@devversion devversion added pr: lgtm target: patch This PR is targeted for the next patch release labels Nov 6, 2019
@gregmagolan gregmagolan changed the title build: allow ng_package patch to silently fail so that issue can be fixed in angular repo [WIP] build: allow ng_package patch to silently fail so that issue can be fixed in angular repo Nov 6, 2019
@gregmagolan
Copy link
Contributor Author

Yes, these npm deps need to brought in now as they are peerDeps of @angular/bazel and no longer direct deps. We've moved a peerDeps pattern for all of the nodejs rules as it makes more sense for the node ecosystem.

Don't merge this yet, I have one last failure on angular/angular#33607 material-unit-tests to resolve: https://app.circleci.com/jobs/github/angular/angular/516209.

gregmagolan added a commit to gregmagolan/angular that referenced this pull request Nov 6, 2019
Temporary commit. DO NOT MERGE UPSTREAM.
@devversion
Copy link
Member

@gregmagolan I see. Thanks for the explanation. Makes sense that they are listed as peer dependencies in @angular/bazel.

gregmagolan added a commit to gregmagolan/angular that referenced this pull request Nov 6, 2019
Temporary commit. DO NOT MERGE UPSTREAM.
@gregmagolan gregmagolan changed the title [WIP] build: allow ng_package patch to silently fail so that issue can be fixed in angular repo build: allow ng_package patch to silently fail so that issue can be fixed in angular repo Nov 6, 2019
@gregmagolan
Copy link
Contributor Author

Ok. All green on the angular repo tested with this branch: https://app.circleci.com/jobs/github/angular/angular/516838

Ready to merge.

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2019
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit bc1c454 into angular:master Nov 6, 2019
gregmagolan added a commit to gregmagolan/angular that referenced this pull request Nov 6, 2019
atscott pushed a commit to angular/angular that referenced this pull request Nov 6, 2019
atscott pushed a commit to angular/angular that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/animations-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/bazel-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/common-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/service-worker-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/platform-server-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/upgrade-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/platform-webworker-dynamic-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/animations-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/platform-webworker-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/bazel-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/router-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/service-worker-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/upgrade-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/common-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/compiler-cli-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/compiler-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/core-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/elements-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/forms-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/language-service-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/localize-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/platform-browser-dynamic-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/platform-browser-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/platform-server-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/platform-webworker-dynamic-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/platform-webworker-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/router-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/service-worker-builds that referenced this pull request Nov 6, 2019
angular-builds pushed a commit to angular/upgrade-builds that referenced this pull request Nov 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants