Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form-field): incorrectly calculating start gap in RTL in the presence of a prefix #18867

Merged
merged 1 commit into from Mar 21, 2020
Merged

fix(form-field): incorrectly calculating start gap in RTL in the presence of a prefix #18867

merged 1 commit into from Mar 21, 2020

Commits on Mar 20, 2020

  1. fix(form-field): incorrectly calculating start gap in RTL in the pres… 

    …ence of a prefix

The logic that figures out the outline gap in the presence of a prefix was producing a negative width which is invalid. It seems like this has been there since the beginning, but we haven't noticed it, because our dev app doesn't have many examples with a prefix and it always starts off from LTR and we switch it to RTL manually which doesn't have this problem since it already got a valid width while it was in LTR.

Fixes angular#18857.
    @crisbeto
    crisbeto committed Mar 20, 2020
    Copy the full SHA
    4ec5eeb View commit details
    Browse the repository at this point in the history