Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk/a11y): Add a new InputModalityDetector service to detect the user's current input modality. #22371
feat(cdk/a11y): Add a new InputModalityDetector service to detect the user's current input modality. #22371
Changes from all commits
e6faf0b
0117c1b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
Document
here will break in SSR because TypeScript preserves type information on decorated params, andDocument
doesn't existing in a nodejs environment. We can use this weird workaround to trick TS into not emitting the type as-is.Can go in a follow-up, but you can test this by adding something to make this API run as part of our
kitchen-sink.ts
component (which is our SSR test component).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the thread at #22371 (comment). The kitchen sink e2e test seems to pass - what should I be looking for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe something changed in the tooling so that we don't have to worry about this any more ¯\(ツ)/¯