New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material-experimental/mdc-button): set proper touch target #22846
Merged
andrewseguin
merged 1 commit into
angular:master
from
crisbeto:22799/mdc-button-touch-target
Jun 7, 2021
Merged
fix(material-experimental/mdc-button): set proper touch target #22846
andrewseguin
merged 1 commit into
angular:master
from
crisbeto:22799/mdc-button-touch-target
Jun 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
The issue is important to a large percentage of users, with a workaround
target: patch
This PR is targeted for the next patch release
labels
May 31, 2021
google-cla
bot
added
the
cla: yes
PR author has agreed to Google's Contributor License Agreement
label
May 31, 2021
mmalerba
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node. Fixes angular#22799.
crisbeto
force-pushed
the
22799/mdc-button-touch-target
branch
from
June 2, 2021 17:35
4cb4e30
to
af46e74
Compare
andrewseguin
added a commit
to andrewseguin/components
that referenced
this pull request
Jun 8, 2021
angular#22846)" This reverts commit 793e1f1.
andrewseguin
added a commit
that referenced
this pull request
Jun 9, 2021
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 9, 2021
This is a reimplementation of angular#22846 which includes a fix for RTL layouts. Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node. Fixes angular#22799.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 9, 2021
This is a reimplementation of angular#22846 which includes a fix for RTL layouts. Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node. Fixes angular#22799.
wagnermaciel
pushed a commit
that referenced
this pull request
Jun 14, 2021
This is a reimplementation of #22846 which includes a fix for RTL layouts. Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node. Fixes #22799.
wagnermaciel
pushed a commit
that referenced
this pull request
Jun 14, 2021
This is a reimplementation of #22846 which includes a fix for RTL layouts. Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node. Fixes #22799. (cherry picked from commit 3284496)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
PR author has agreed to Google's Contributor License Agreement
P2
The issue is important to a large percentage of users, with a workaround
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some styles to ensure that the MDC-based button always has a touch target of at least 48px. Note that I decided against using MDC's built-in touch target class, because it would've added a margin on the button host node.
Fixes #22799.
For reference, here's what the touch targets look like at different densities: