Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-tabs): ink bar animation not always disabled #22848

Merged
merged 1 commit into from Jun 10, 2021
Merged

fix(material-experimental/mdc-tabs): ink bar animation not always disabled #22848

merged 1 commit into from Jun 10, 2021

Commits on May 31, 2021

  1. fix(material-experimental/mdc-tabs): ink bar animation not always dis… 

    …abled

Fixes an issue where, in some cases, the load order can re-enable the ink bar animation that was disabled via the `NoopAnimationsModule`. This is noticeable by landing on the MDC input demo page with disabled animations and navigating to the MDC tabs demo page.

The issue seems to be caused by the fact that the two demos are in separate modules which causes Angular to insert the tab styles again when the user switches between them. Since the styles that disable the animation had the same specificity as the animation definition, swapping the loading order could cause them to be overwritten.
    @crisbeto
    crisbeto committed May 31, 2021
    Copy the full SHA
    e411c2b View commit details
    Browse the repository at this point in the history