Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-slider): delete isRequired function #22876

Merged
merged 2 commits into from Jun 10, 2021
Merged

fix(material-experimental/mdc-slider): delete isRequired function #22876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e0d811
fix(material-experimental/mdc-slider): delete isRequired function
wagnermaciel Jun 3, 2021
e476840
fixup! fix(material-experimental/mdc-slider): delete isRequired function
wagnermaciel Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/material-experimental/mdc-slider/testing/slider-harness.spec.ts
View file
Open in desktop
Expand Up @@ -145,11 +145,6 @@ describe('MDC-based MatSliderHarness', () => {
expect(await (await slider.getStartThumb()).getId()).toBe('price-input');
});

it('should get whether a slider thumb is required', async () => {
const slider = await loader.getHarness(MatSliderHarness);
expect(await (await slider.getStartThumb()).isRequired()).toBe(true);
});

it('should be able to focus and blur a slider thumb', async () => {
const slider = await loader.getHarness(MatSliderHarness);
const thumb = await slider.getStartThumb();
Expand All @@ -169,7 +164,6 @@ describe('MDC-based MatSliderHarness', () => {
<input
name="price"
id="price-input"
required
matSliderThumb
(input)="inputListener()"
(change)="changeListener()">
Expand Down
5 changes: 0 additions & 5 deletions src/material-experimental/mdc-slider/testing/slider-thumb-harness.ts
View file
Open in desktop
Expand Up @@ -82,11 +82,6 @@ export class MatSliderThumbHarness extends ComponentHarness {
return (await this.host()).getProperty('disabled');
}

/** Whether the thumb is required. */
async isRequired(): Promise<boolean> {
return (await this.host()).getProperty('required');
}

/** Gets the name of the thumb. */
async getName(): Promise<string> {
return (await (await this.host()).getProperty('name'));
Expand Down