Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-slider): remove deep imports #23451

Merged
merged 1 commit into from Sep 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions rollup-globals.bzl
Expand Up @@ -39,10 +39,6 @@ ROLLUP_GLOBALS = {
"@angular/material-date-fns-adapter": "ng.materialDateFnsAdapter",
"@angular/youtube-player": "ng.youtubePlayer",

# This UMD module name would not match with anything that MDC provides, but we just
# add this to make the linter happy. This module resolves to a type-only file anyways.
"@material/base/types": "mdc.base.types",

# Third-party libraries.
"kagekiri": "kagekiri",
"moment": "moment",
Expand Down
1 change: 1 addition & 0 deletions src/material-experimental/mdc-slider/BUILD.bazel
Expand Up @@ -27,6 +27,7 @@ ng_module(
"//src/cdk/platform",
"//src/material-experimental/mdc-core",
"@npm//@angular/forms",
"@npm//@material/base",
"@npm//@material/slider",
],
)
Expand Down
Expand Up @@ -8,7 +8,7 @@

import {DOCUMENT} from '@angular/common';
import {Inject, Injectable, NgZone, OnDestroy} from '@angular/core';
import {SpecificEventListener} from '@material/base/types';
import {SpecificEventListener} from '@material/base';
import {fromEvent, Observable, Subject, Subscription} from 'rxjs';
import {finalize, share, takeUntil} from 'rxjs/operators';

Expand Down
2 changes: 1 addition & 1 deletion src/material-experimental/mdc-slider/slider.ts
Expand Up @@ -50,7 +50,7 @@ import {
RippleState,
} from '@angular/material/core';
import {ANIMATION_MODULE_TYPE} from '@angular/platform-browser/animations';
import {SpecificEventListener, EventType} from '@material/base/types';
import {SpecificEventListener, EventType} from '@material/base';
import {MDCSliderAdapter, MDCSliderFoundation, Thumb, TickMark} from '@material/slider';
import {Subscription} from 'rxjs';
import {GlobalChangeAndInputListener} from './global-change-and-input-listener';
Expand Down