feat(material/schematics): tree operation helper functions #24539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wagnermaciel
commented
Mar 7, 2022
wagnermaciel
commented
- created tree-traversal.ts for storing tree operation helper fns
- moved visitElements to the new file
- created helper fns for parseTemplate, and tag name changes
- added unit tests which don't need to call the whole schematic
* created tree-traversal.ts for storing tree operation helper fns * moved visitElements to the new file * created helper fns for parseTemplate, and tag name changes * added unit tests which don't need to call the whole schematic
wagnermaciel
requested review from
amysorto
and removed request for
andrewseguin
wagnermaciel
added
the
target: feature
amysorto
approved these changes
Mar 7, 2022
src/material/schematics/ng-generate/mdc-migration/rules/tree-traversal.ts
Outdated
Show resolved
Hide resolved
| if (!node.endSourceSpan) { | ||
| return html; | ||
| } | ||
| return replaceAt(html, node.endSourceSpan.start.offset + 2, node.name, tag); |
There was a problem hiding this comment.
where is this 2 coming from?
There was a problem hiding this comment.
The 2 comes from the </ at the beginning of html end tags
src/material/schematics/ng-generate/mdc-migration/rules/tree-traversal.ts
Outdated
Show resolved
Hide resolved
devversion
pushed a commit
to devversion/material2
that referenced
this pull request
Mar 14, 2022
…4539) * feat(material/schematics): tree operation helper functions * created tree-traversal.ts for storing tree operation helper fns * moved visitElements to the new file * created helper fns for parseTemplate, and tag name changes * added unit tests which don't need to call the whole schematic
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.