feat(material/schematics): add fn for adding attrs to templates

[wagnermaciel]

• create and unit test addAttribute fn

[devversion]

LGTM, a test scnario for multiple arguments on a single element would be cool.

[wagnermaciel]

LGTM, a test scnario for multiple arguments on a single element would be cool.

@devversion That's outside of the scope of what's needed for the migration. We'll only need to add a single one. Would be easy to add that functionality in if it becomes relevant in the future

[devversion]

@devversion That's outside of the scope of what's needed for the migration. We'll only need to add a single one. Would be easy to add that functionality in if it becomes relevant in the future

My philosophy usually is: if you are building a generic utility like this, and this is a common scenario usually, then it should be tested as it's low-effort (4-5 lines), proofs that the API can be useful for other usages as well, and works (because future uses might not be testing all code paths -- its easy to forget about this then 😛 )

[wagnermaciel]

@devversion I think I may have misunderstood you. Did you want to test using the addAttribute fn multiple times or extend and then test the functionality of addAttribute so that it could add multiple attributes like this

addAttribute(html: string, node: Element, attributes: {[key: string]: string}[])

[devversion]

@wagnermaciel I was just thinking of having a test where you'd call addAttribute multiple times. Sorry if that was unclear.

[wagnermaciel]

@devversion Ah, gotcha. No problem then, I'll just throw in a test for it in a follow-up PR 👍🏽

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}