Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/schematics): add template migration to schematic #24563

Merged
merged 2 commits into from Mar 10, 2022
Merged

feat(material/schematics): add template migration to schematic #24563

merged 2 commits into from Mar 10, 2022

Conversation

wagnermaciel
Copy link
Contributor

  • create ComponentMigrator interface to store the
    different types of migrations for each component
  • refactor individual migrations to work with ComponentMigrator
  • add missing unit test for addAttribute
  • create TemplateMigrator to unify the interface
    for template migrations

@wagnermaciel wagnermaciel added the target: feature This PR is targeted for a feature branch (outside of main and semver branches) label Mar 10, 2022
amysorto
amysorto approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@amysorto amysorto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel
feat(material/schematics): add template migration to schematic
7e3d16f 
* create ComponentMigrator interface to store the
  different types of migrations for each component
* refactor individual migrations to work with ComponentMigrator
* add missing unit test for addAttribute
* create TemplateMigrator to unify the interface
  for template migrations
@wagnermaciel
fixup! feat(material/schematics): add template migration to schematic
96f903d
devversion
devversion approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wagnermaciel wagnermaciel merged commit dbade7d into angular:mdc-migration Mar 10, 2022
devversion pushed a commit to devversion/material2 that referenced this pull request Mar 14, 2022
@wagnermaciel @devversion
feat(material/schematics): add template migration to schematic (angul…
96cff56 
…ar#24563)

* create ComponentMigrator interface to store the
  different types of migrations for each component
* refactor individual migrations to work with ComponentMigrator
* add missing unit test for addAttribute
* create TemplateMigrator to unify the interface
  for template migrations
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@amysorto amysorto amysorto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

Assignees
No one assigned
Labels
target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wagnermaciel @devversion @amysorto