Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/schematics): impl card template migration #24566

Merged
merged 2 commits into from Mar 10, 2022
Merged

feat(material/schematics): impl card template migration #24566

merged 2 commits into from Mar 10, 2022

Conversation

wagnermaciel
Copy link
Contributor

  • implement TemplateMigrator for mat-card
  • add unit tests for card template migrations
  • implement migration updates in TemplateMigration
  • added CardTemplateMigrator to list of MIGRATORS

@wagnermaciel
feat(material/schematics): impl card template migration
0beb356 
* implement TemplateMigrator for mat-card
* add unit tests for card template migrations
* implement migration updates in TemplateMigration
* added CardTemplateMigrator to list of MIGRATORS
@wagnermaciel wagnermaciel added the target: feature This PR is targeted for a feature branch (outside of main and semver branches) label Mar 10, 2022
amysorto
amysorto approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@amysorto amysorto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from comment

src/material/schematics/ng-generate/mdc-migration/rules/components/card/card-template.ts Outdated Show resolved Hide resolved
@wagnermaciel wagnermaciel merged commit e5a990a into angular:mdc-migration Mar 10, 2022
devversion pushed a commit to devversion/material2 that referenced this pull request Mar 14, 2022
@wagnermaciel @devversion
feat(material/schematics): impl card template migration (angular#24566)
31371e7 
* implement TemplateMigrator for mat-card
* add unit tests for card template migrations
* implement migration updates in TemplateMigration
* added CardTemplateMigrator to list of MIGRATORS
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@amysorto amysorto amysorto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

Assignees
No one assigned
Labels
target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wagnermaciel @devversion @amysorto