feat(material/schematics): add chips template migrator #24601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnermaciel
requested review from
amysorto
and removed request for
andrewseguin
wagnermaciel
added
the
target: feature
devversion
approved these changes
Mar 16, 2022
src/material/schematics/ng-generate/mdc-migration/rules/components/chips/chips-template.ts
Outdated
Show resolved
Hide resolved
src/material/schematics/ng-generate/mdc-migration/rules/components/chips/chips-template.ts
Outdated
Show resolved
Hide resolved
src/material/schematics/ng-generate/mdc-migration/rules/components/chips/chips-template.ts
Outdated
Show resolved
Hide resolved
devversion
reviewed
Mar 18, 2022
src/material/schematics/ng-generate/mdc-migration/rules/components/chips/chips-template.ts
Outdated
Show resolved
Hide resolved
devversion
approved these changes
Mar 31, 2022
src/material/schematics/ng-generate/mdc-migration/rules/components/chips/chips-template.ts
Outdated
Show resolved
Hide resolved
src/material/schematics/ng-generate/mdc-migration/rules/components/chips/chips-template.ts
Show resolved
Hide resolved
mmalerba
reviewed
Apr 1, 2022
src/material/schematics/ng-generate/mdc-migration/rules/components/chips/chips-template.ts
Show resolved
Hide resolved
* impl ChipsTemplateMigrator and added it to list of migrators * remove unnecessary class vars from TemplateMigrator * added onComplete callback to TemplateMigrator to make handling state in TemplateMigrators simpler * unit tested
wagnermaciel
force-pushed
the
template-migration
branch
from
5a3f7a0
to
b0e7d6b
Compare
wagnermaciel
added a commit
that referenced
this pull request
Apr 18, 2022
* feat(material/schematics): add chips template migrator * refactor some of the template migrator logic * impl ChipsTemplateMigrator and added it to list of migrators * remove unnecessary class vars from TemplateMigrator * unit tested
wagnermaciel
added a commit
that referenced
this pull request
Apr 28, 2022
* feat(material/schematics): add chips template migrator * refactor some of the template migrator logic * impl ChipsTemplateMigrator and added it to list of migrators * remove unnecessary class vars from TemplateMigrator * unit tested
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handling state in TemplateMigrators simpler