Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): announce the "to" when reading year range #24958

Merged
merged 1 commit into from Sep 19, 2022
Merged

fix(material/datepicker): announce the "to" when reading year range #24958

merged 1 commit into from Sep 19, 2022

Conversation

zarend
Copy link
Contributor

@zarend zarend commented May 23, 2022 •
edited 

fix(material/datepicker): announce the "to" when reading year range

Create period button's `aria-description` using `formatYearRangeLabel`
method. Format year range in a TTS friendly way (e.g. "2019 to 2020").
Previously, some screen readers would announce the range as "2019 2020".

Fixes #23467.

@zarend zarend added Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release area: material/datepicker dev-app preview When applied, previews of the dev-app are deployed to Firebase labels May 23, 2022
@github-actions
Copy link

github-actions bot commented May 23, 2022 •
edited

Deployed dev-app to: https://ng-comp-dev--pr-24958-63c304508e133feea032935c14ad9429-lsqxjkw0.web.app

@zarend zarend requested a review from mmalerba May 25, 2022 20:11
@zarend zarend force-pushed the datepicker-to branch 2 times, most recently from 2bd390e to 2bba0e1 Compare June 7, 2022 20:39
@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Jun 8, 2022
@zarend zarend added this to In progress (review, presubmit) in Datepicker Accessibility via automation Sep 16, 2022
@zarend zarend force-pushed the datepicker-to branch 2 times, most recently from e5f67ca to d7114ad Compare September 17, 2022 00:24
@zarend
fix(material/datepicker): announce the "to" when reading year range
354a490 
Create period button's `aria-description` using `formatYearRangeLabel`
method. Format year range in a TTS friendly way (e.g. "2019 to 2020").
Previously, some screen readers would announce the range as "2019 2020".

Fixes angular#23467.
@zarend zarend merged commit 2704c31 into angular:main Sep 19, 2022
Datepicker Accessibility automation moved this from In progress (review, presubmit) to Done Sep 19, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner

Assignees

@zarend zarend

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/datepicker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: minor This PR is targeted for the next minor release
Projects
Datepicker Accessibility
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zarend @mmalerba