Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/progress-bar): Switch progress-bar implementation to use MDC #25234

Merged
merged 5 commits into from Jul 21, 2022
Merged

feat(material/progress-bar): Switch progress-bar implementation to use MDC #25234

merged 5 commits into from Jul 21, 2022

Conversation

wagnermaciel
Copy link
Contributor

Old implementation is still available under @angular/material/legacy-progress-bar

BREAKING CHANGE:

  • DOM and CSS classes for mat-progress-bar have changes
  • Typescript API is largely the same but may have minor differences
  • See the MDC migration guide for more information about the changes and
    how to migrate your app (TODO: link when available)

@wagnermaciel wagnermaciel force-pushed the mdc-progress-bar-folder-change branch 9 times, most recently from 0be06ba to 297421e Compare July 12, 2022 19:36
@wagnermaciel wagnermaciel marked this pull request as ready for review July 12, 2022 19:51
@wagnermaciel wagnermaciel added target: major This PR is targeted for the next major release flag: breaking change labels Jul 12, 2022
mmalerba
mmalerba approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see http://cl/457155286 as a reference for the changes you may need to make on the google3 side

@josephperrott josephperrott removed the request for review from a team July 13, 2022 18:30
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jul 14, 2022
@wagnermaciel wagnermaciel force-pushed the mdc-progress-bar-folder-change branch from 297421e to 2a1e03d Compare July 18, 2022 14:22
@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Jul 19, 2022
@wagnermaciel wagnermaciel merged commit f384c24 into angular:main Jul 21, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner

@devversion devversion Awaiting requested review from devversion devversion is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wagnermaciel @mmalerba