fix(material/card): don't add extra padding around mat-card-title-group #25292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The card demo page forgot to include mat-card-header which caused many of the cards to look strange. At some point it looks like padding was added to mat-card-title-group to compensate in some cases. This PR removes that padding and adds the missing mat-card-header blocks instead.
mmalerba
added
the
dev-app preview
|
Deployed dev-app to: https://ng-comp-dev--pr-25292-30a31526ebd3d0328194e8d1c35a70c8-fz1pn6ul.web.app |
mmalerba
force-pushed
the
mdc-card-header
branch
from
70bde7a
to
30a3152
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This change is for the MDC-based card (now called material/card)
The card demo page forgot to include mat-card-header which caused many
of the cards to look strange. At some point it looks like padding was
added to mat-card-title-group to compensate in some cases. This PR
removes that padding and adds the missing mat-card-header blocks
instead.