Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/schematics): add style migration support within typescipt files #25339

Merged
merged 1 commit into from Aug 16, 2022

Conversation

amysorto
Copy link
Contributor

No description provided.

@amysorto amysorto added target: major This PR is targeted for the next major release area: ng-generate Schematics that generate code in user projects labels Jul 25, 2022
@devversion devversion removed their request for review August 2, 2022 10:39
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

".mat-mdc-button { padding: 12px; }",
\`
/* TODO: The following rule targets internal classes of button that may no longer apply for the MDC version. */
\n ::ng-deep .mat-button-wrapper{ color: darkblue; }\`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just documenting in case anyone else wonders the same thing:
This \n in the string literal doesn't break angular compilation

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Aug 16, 2022
@amysorto amysorto merged commit 0554f18 into angular:main Aug 16, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: ng-generate Schematics that generate code in user projects target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants