Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/core): switch option implementation to use MDC #25343

Merged
merged 1 commit into from Jul 28, 2022
Merged

feat(material/core): switch option implementation to use MDC #25343

merged 1 commit into from Jul 28, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 26, 2022 •
edited

Switches the implementation of mat-option and mat-optgroup to use MDC by default.

BREAKING CHANGE:

  • DOM and CSS classes for mat-option and mat-optgroup have changed.
  • Typescript API is largely the same but may have minor differences

@crisbeto crisbeto force-pushed the mdc-select-move branch 18 times, most recently from fde3314 to ad20b16 Compare July 28, 2022 11:26
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Jul 28, 2022
@crisbeto crisbeto marked this pull request as ready for review July 28, 2022 12:15
@mmalerba
Copy link
Contributor

should add a BREAKING CHANGE clause to the commit message like I did for card: #25082

@crisbeto
feat(material/core): switch option implementation to use MDC
32067e8 
Switches the implementation of `mat-option` and `mat-optgroup` to use MDC by default.

BREAKING CHANGE:
* DOM and CSS classes for `mat-option` and `mat-optgroup` have changed.
* Typescript API is largely the same but may have minor differences
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker flag: breaking change labels Jul 28, 2022
@crisbeto crisbeto merged commit 5b8d521 into angular:main Jul 28, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion devversion is a code owner

@josephperrott josephperrott Awaiting requested review from josephperrott josephperrott is a code owner

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crisbeto @mmalerba