fix(material/dialog): using incorrect mixin for structural styles #25356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
devversion
approved these changes
Jul 29, 2022
The MDC dialog was using the `core-styles` mixin instead of the `static-styles` which is supposed to be used together with the new theming API. I've also removed the `container-elevation` and `container-shadow-color` variables from the theme since they weren't doing anything.
crisbeto
force-pushed
the
mdc-dialog-wrong-mixin
branch
from
e7bb408
to
f28af4b
Compare
crisbeto
changed the title
crisbeto
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MDC dialog was using the
core-stylesmixin instead of thestatic-styleswhich is supposed to be used together with the new theming API. I've also removed thecontainer-elevationandcontainer-shadow-colorvariables from the theme since they weren't doing anything.