feat(material/select): switch implementation to use MDC #25360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches `mat-select` to use MDC by default. BREAKING CHANGE: * DOM and CSS classes for `mat-select` have changes. * TypeScript API is largely the same but may have minor differences.
crisbeto
force-pushed
the
mdc-select-move-2
branch
from
e3474df
to
918d952
Compare
crisbeto
added
P2
crisbeto
force-pushed
the
mdc-select-move-2
branch
from
c4b83a8
to
918d952
Compare
crisbeto
requested review from
devversion,
josephperrott,
andrewseguin,
jelbourn,
mmalerba and
zarend
as code owners
andrewseguin
approved these changes
Aug 1, 2022
wagnermaciel
reviewed
Aug 1, 2022
| */ | ||
|
|
||
| /** The max height of the select's overlay panel. */ | ||
| export const SELECT_PANEL_MAX_HEIGHT = 256; |
There was a problem hiding this comment.
Are we meant to prefix these exports with LEGACY_ as well?
There was a problem hiding this comment.
My understanding was that we're only supposed to do the Mat* symbols, but I could be wrong.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches
mat-selectto use MDC by default.BREAKING CHANGE:
mat-selecthave changes.