Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/checkbox): switch implementation to use MDC #25369

Merged
merged 2 commits into from Aug 4, 2022
Merged

feat(material/checkbox): switch implementation to use MDC #25369

merged 2 commits into from Aug 4, 2022

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Aug 1, 2022 •
edited

BREAKING CHANGE:

  • DOM and CSS classes for mat-checkbox have changes
  • Typescript API is largely the same but may have minor differences
  • See the MDC migration guide for more information about the changes and how to migrate your app (TODO: link when available)

@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Aug 1, 2022
@andrewseguin andrewseguin marked this pull request as ready for review August 1, 2022 23:04
@andrewseguin andrewseguin force-pushed the migrate-checkbox branch 5 times, most recently from da1e247 to f6b6757 Compare August 2, 2022 14:01
mmalerba
mmalerba approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 2, 2022
@mmalerba
Copy link
Contributor

mmalerba commented Aug 2, 2022

Can you add a BREAKING CHANGE clause to the commit message?

@andrewseguin andrewseguin merged commit 9ac264f into angular:main Aug 4, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner

@devversion devversion Awaiting requested review from devversion devversion is a code owner

@josephperrott josephperrott Awaiting requested review from josephperrott josephperrott is a code owner

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

@zarend zarend Awaiting requested review from zarend

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewseguin @mmalerba