Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk/listbox): add listbox to cdk #25380

Merged
merged 2 commits into from Aug 16, 2022
Merged

feat(cdk/listbox): add listbox to cdk #25380

merged 2 commits into from Aug 16, 2022

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 2, 2022

graduates listbox from cdk-experimental to cdk

@mmalerba mmalerba added the target: minor This PR is targeted for the next minor release label Aug 2, 2022
@mmalerba mmalerba requested a review from jelbourn as a code owner August 2, 2022 20:00
@mmalerba mmalerba added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

@mmalerba
Copy link
Contributor Author

mmalerba commented Aug 4, 2022

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through with a screen reader, but played with the examples and they seem good. If you've gone through a pass of SR testing it seems good to me.

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 12, 2022
@mmalerba mmalerba added target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Aug 16, 2022
@mmalerba mmalerba merged commit 0734564 into angular:main Aug 16, 2022
@zarend
Copy link
Contributor

zarend commented Aug 16, 2022

🎉

mmalerba added a commit to mmalerba/components that referenced this pull request Aug 16, 2022
* feat(cdk/listbox): add listbox to cdk

* fixup! feat(cdk/listbox): add listbox to cdk
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Sep 1, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.1.3/14.2.0) |
| [@angular/material](https://github.com/angular/components) | dependencies | minor | [`14.1.3` -> `14.2.0`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.1.3/14.2.0) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.2.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1420-rayon-river-2022-08-25)

[Compare Source](angular/components@14.1.3...14.2.0)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [06c2164618](angular/components@06c2164) | feat | **a11y:** add named export and public property to CdkMonitorFocus directive ([#&#8203;25427](angular/components#25427)) |
| [0fb2e9a5f7](angular/components@0fb2e9a) | feat | **listbox:** add listbox to cdk ([#&#8203;25380](angular/components#25380)) ([#&#8203;25474](angular/components#25474)) |
| [79858ea14b](angular/components@79858ea) | fix | **scrolling:** error during server-side rendering ([#&#8203;25461](angular/components#25461)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [657774e29b](angular/components@657774e) | feat | **datepicker:** Allow user to jump between start and end dates with arrow keys ([#&#8203;25359](angular/components#25359)) |

##### cdk-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [aaa9d93c92](angular/components@aaa9d93) | fix | **listbox:** fix issue with aria-selected ([#&#8203;25373](angular/components#25373)) |

#### Special Thanks

Andrew Seguin, Emmanuel Roux, Joey Perrott, Karl Seamon, Kristiyan Kostadinov, Miles Malerba, Paul Gschwendtner and Wagner Maciel

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNzQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE3Ny4xIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1522
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants