feat(material/button): Switch button implementation to use MDC #25381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amysorto
force-pushed
the
move-button-to-mdc
branch
7 times, most recently
from
c93bc68
to
09ecac4
Compare
amysorto
force-pushed
the
move-button-to-mdc
branch
3 times, most recently
from
0893bef
to
87541a2
Compare
amysorto
force-pushed
the
move-button-to-mdc
branch
from
87541a2
to
3278ef1
Compare
amysorto
requested review from
devversion,
josephperrott,
andrewseguin,
jelbourn,
mmalerba,
crisbeto and
zarend
as code owners
mmalerba
reviewed
Aug 11, 2022
mmalerba
approved these changes
Aug 11, 2022
mmalerba
requested changes
Aug 11, 2022
Switches the implementation of mat-button, mat-fab, and mat-icon-button to use MDC by default. BREAKING CHANGE: DOM and CSS classes for mat-button, mat-fab, and mat-icon-button have changed. Typescript API is largely the same but may have minor differences.
amysorto
force-pushed
the
move-button-to-mdc
branch
from
3278ef1
to
e0cc255
Compare
|
I changed MatAnchor to MatLegacyAnchor. I didn't see anything else when I took another look. |
mmalerba
approved these changes
Aug 12, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the implementation of mat-button, mat-fab, and mat-icon-button to use MDC by default.
BREAKING CHANGE:
DOM and CSS classes for mat-button, mat-fab, and mat-icon-button have changed.
Typescript API is largely the same but may have minor differences.