Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/autocomplete): switch implementation to use MDC #25386

Merged
merged 1 commit into from Aug 4, 2022
Merged

feat(material/autocomplete): switch implementation to use MDC #25386

merged 1 commit into from Aug 4, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 3, 2022

Switches mat-autocomplete to use MDC by default.

BREAKING CHANGE:

  • DOM and CSS classes for mat-autocomplete have changes.
  • TypeScript API is largely the same but may have minor differences.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Aug 3, 2022
@crisbeto
feat(material/autocomplete): switch implementation to use MDC
a98c246 
Switches `mat-autocomplete` to use MDC by default.

BREAKING CHANGE:

* DOM and CSS classes for `mat-autocomplete` have changes.
* TypeScript API is largely the same but may have minor differences.
@crisbeto crisbeto marked this pull request as ready for review August 3, 2022 08:35
mmalerba
mmalerba approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 3, 2022
@crisbeto crisbeto merged commit 532454b into angular:main Aug 4, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion devversion is a code owner

@josephperrott josephperrott Awaiting requested review from josephperrott josephperrott is a code owner

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crisbeto @mmalerba