Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/slide-toggle): Switch slide-toggle implementation to use MDC #25404

Merged
merged 1 commit into from Aug 8, 2022

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 5, 2022

Old implementation is still available under @angular/material/legacy-slide-toggle

BREAKING CHANGE:

  • DOM and CSS classes for mat-slide-toggle have changes
  • Typescript API is largely the same but may have minor differences
  • See the MDC migration guide for more information about the changes and
    how to migrate your app (TODO: link when available)

@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Aug 5, 2022
@mmalerba mmalerba force-pushed the mdc-slide-toggle branch 3 times, most recently from 70caac8 to a40bd68 Compare August 6, 2022 00:01
…e MDC

Old implementation is still available under @angular/material/legacy-slide-toggle

BREAKING CHANGE:

- DOM and CSS classes for mat-slide-toggle have changes
- Typescript API is largely the same but may have minor differences
- See the MDC migration guide for more information about the changes and
how to migrate your app (TODO: link when available)
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 8, 2022
@mmalerba mmalerba merged commit a1bb436 into angular:main Aug 8, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants