Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/menu): switch implementation to use MDC #25431

Merged
merged 1 commit into from Aug 10, 2022

Conversation

crisbeto
Copy link
Member

Switches the material/menu implementation to use MDC by default. Old implementation is still available under material/legacy-menu.

BREAKING CHANGE:

  • DOM and CSS classes for mat-menu have changes.
  • Typescript API is largely the same but may have minor differences.

@crisbeto crisbeto force-pushed the mdc-menu-move branch 2 times, most recently from 456fbbe to b31ce13 Compare August 10, 2022 07:10
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Aug 10, 2022
@crisbeto
Copy link
Member Author

This one's ready for review. The test failures are because of an unrelated tooltip change that is in the process of being reverted.

@crisbeto crisbeto marked this pull request as ready for review August 10, 2022 07:25
Switches the `material/menu` implementation to use MDC by default. Old implementation is still available under `material/legacy-menu`.

BREAKING CHANGE:
- DOM and CSS classes for `mat-menu` have changes.
- Typescript API is largely the same but may have minor differences.
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Aug 10, 2022
@crisbeto crisbeto merged commit 20db76d into angular:main Aug 10, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants