Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/list): switch implementation to use MDC list #25445

Merged
merged 1 commit into from Aug 11, 2022
Merged

feat(material/list): switch implementation to use MDC list #25445

merged 1 commit into from Aug 11, 2022

Conversation

crisbeto
Copy link
Member

Switches the material/list implementation to use MDC by default. Old implementation is still available under material/legacy-list.

BREAKING CHANGE:

  • DOM and CSS classes for the various list components have changed.
  • Typescript API is largely the same but may have minor differences.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Aug 11, 2022
@crisbeto
feat(material/list): switch implementation to use MDC list
7506cca 
Switches the `material/list` implementation to use MDC by default. Old implementation is still available under `material/legacy-list`.

BREAKING CHANGE:
- DOM and CSS classes for the various list components have changed.
- Typescript API is largely the same but may have minor differences.
@crisbeto crisbeto marked this pull request as ready for review August 11, 2022 07:15
devversion
devversion approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crisbeto crisbeto self-assigned this Aug 11, 2022
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 11, 2022
@crisbeto crisbeto merged commit 5f0f071 into angular:main Aug 11, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner

@josephperrott josephperrott Awaiting requested review from josephperrott josephperrott is a code owner

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crisbeto @devversion