feat(material/table): migrate MDC examples #25492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
the
target: major
andrewseguin
force-pushed
the
migrate-table-examples
branch
2 times, most recently
from
629911d
to
fd2d087
Compare
mmalerba
reviewed
Aug 18, 2022
...ponents-examples/material/table/table-generated-columns/table-generated-columns-example.html
Outdated
Show resolved
Hide resolved
src/components-examples/material/table/table-http/table-http-example.html
Outdated
Show resolved
Hide resolved
src/components-examples/material/table/table-sorting/table-sorting-example.ts
Show resolved
Hide resolved
|
@mmalerba Oof thanks for the review, I made the assumption that the examples were synced up. Will revisit these in the morning to fix up the discrepancies |
andrewseguin
commented
Aug 19, 2022
...ponents-examples/material/table/table-generated-columns/table-generated-columns-example.html
Outdated
Show resolved
Hide resolved
src/components-examples/material/table/table-http/table-http-example.html
Outdated
Show resolved
Hide resolved
src/components-examples/material/table/table-sorting/table-sorting-example.ts
Show resolved
Hide resolved
andrewseguin
force-pushed
the
migrate-table-examples
branch
2 times, most recently
from
c6f2f98
to
a262f2d
Compare
|
The diff on GitHub is weird because it is confused about some moves. Fixing now EDIT: Fixing didnt help, GitHub just renders some diffs off (e.g. thinking I moved some mdc files to legacy) |
andrewseguin
force-pushed
the
migrate-table-examples
branch
2 times, most recently
from
9752b41
to
974df1d
Compare
andrewseguin
force-pushed
the
migrate-table-examples
branch
from
974df1d
to
1799fbb
Compare
mmalerba
approved these changes
Aug 19, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.