Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/core): Move remaining MDC core functionality out of experimental #25503

Merged
merged 1 commit into from Aug 22, 2022
Merged

fix(material/core): Move remaining MDC core functionality out of experimental #25503

merged 1 commit into from Aug 22, 2022

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba changed the title fix(material-experimental): align mdc-core sass with core sass fix(material-experimental/mdc-core): align mdc-core sass with core sass Aug 19, 2022
@mmalerba mmalerba changed the title fix(material-experimental/mdc-core): align mdc-core sass with core sass fix(material/core): Move remaining MDC core functionality out of experimental Aug 20, 2022
@mmalerba mmalerba force-pushed the mdc-core-cleanup branch 2 times, most recently from 555b304 to 6520a3d Compare August 21, 2022 05:49
@mmalerba mmalerba marked this pull request as ready for review August 21, 2022 05:50
@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Aug 21, 2022
crisbeto
crisbeto reviewed Aug 21, 2022
View reviewed changes
src/e2e-app/theme.scss Show resolved Hide resolved
src/material/core/typography/_all-typography.scss Show resolved Hide resolved
src/universal-app/theme.scss Show resolved Hide resolved
crisbeto
crisbeto approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 22, 2022
@mmalerba mmalerba merged commit fd5afe7 into angular:main Aug 22, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion devversion is a code owner

@josephperrott josephperrott Awaiting requested review from josephperrott josephperrott is a code owner

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmalerba @crisbeto @andrewseguin