Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/dialog): allow customizing animation duration #25524

Merged
merged 2 commits into from Aug 29, 2022
Merged

fix(material/dialog): allow customizing animation duration #25524

merged 2 commits into from Aug 29, 2022

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 24, 2022 •
edited

BREAKING CHANGE:

  • Passing strings for MatDialogConfig.enterAnimationDuration and
    MatDialogConfig.exitAnimationDuration is deprecated, pass numbers
    in ms instead

@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Aug 24, 2022
@mmalerba mmalerba force-pushed the dialog-docs branch 2 times, most recently from a1d4c13 to 64f12fb Compare August 25, 2022 17:23
@mmalerba
fix(material/dialog): allow customizing animation duration
d3382f6 
BREAKING CHANGE:
- Passing strings for MatDialogConfig.enterAnimationDuration and
  MatDialogConfig.exitAnimationDuration is deprecated, pass numbers
  in ms instead
@mmalerba mmalerba force-pushed the dialog-docs branch 6 times, most recently from b74cee6 to 2336100 Compare August 26, 2022 00:09
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 26, 2022
@devversion devversion removed their request for review August 29, 2022 11:56
@josephperrott josephperrott removed their request for review August 29, 2022 18:30
@mmalerba mmalerba merged commit 4cdc095 into angular:main Aug 29, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Sep 16, 2022
@mmalerba
fix(material/dialog): allow customizing animation duration (angular#2…
64047f0 
…5524)

* fix(material/dialog): allow customizing animation duration

BREAKING CHANGE:
- Passing strings for MatDialogConfig.enterAnimationDuration and
  MatDialogConfig.exitAnimationDuration is deprecated, pass numbers
  in ms instead

* deprecate the string animation durations in favor of numbers
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmalerba @crisbeto @andrewseguin