Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/legacy-form-field): remove invalid selector #25554

Merged
merged 1 commit into from Sep 1, 2022
Merged

fix(material/legacy-form-field): remove invalid selector #25554

merged 1 commit into from Sep 1, 2022

Conversation

crisbeto
Copy link
Member

We used to use :placeholder-shown to toggle some styles in the form field. In #8223 those selectors were changed to :label-shown which isn't a valid CSS selector.

These changes remove the selector since it can cause errors in some tools.

Fixes #24181.

@crisbeto
fix(material/legacy-form-field): remove invalid selector
15f9ae5 
We used to use `:placeholder-shown` to toggle some styles in the form field. In angular#8223 those selectors were changed to `:label-shown` which isn't a valid CSS selector.

These changes remove the selector since it can cause errors in some tools.

Fixes angular#24181.
@crisbeto crisbeto added target: patch This PR is targeted for the next patch release P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Aug 30, 2022
mmalerba
mmalerba approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 31, 2022
@crisbeto crisbeto added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 1, 2022
@crisbeto crisbeto merged commit 86c4a9d into angular:main Sep 1, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Sep 16, 2022
@crisbeto
fix(material/legacy-form-field): remove invalid selector (angular#25554)
a6e0419 
We used to use `:placeholder-shown` to toggle some styles in the form field. In angular#8223 those selectors were changed to `:label-shown` which isn't a valid CSS selector.

These changes remove the selector since it can cause errors in some tools.

Fixes angular#24181.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-form-field: ":label-shown" pseudoclass
2 participants
@crisbeto @mmalerba