New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch datepicker to MDC #25573
Switch datepicker to MDC #25573
Conversation
72ac31d
to
7babbfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that there's a potential issue with this. If we just switch it to the MDC version, people might not have the appropriate theme in their app.
We'll have to figure out how we want to handle this, here's a few ideas:
- Split out a legacy-datepicker that retains the legacy deps
- Have
ng update
automatically add the button theme when people update to v15 - Have the datepicker theme mixins @include the button one
- Have some back-compat mixin that
ng update
adds andng generate
removes after migrating the button:@mixin datepicker-back-compat-theme($theme) { .mat-datepicker { @include mat.button-theme($theme); } }
7babbfc
to
33444bf
Compare
Switches the datepicker to use the MDC button, form field and input.
Switches the datepicker docs and demos to use MDC.
8016f79
to
5eaf859
Compare
This is ready to review again. I've added a |
Adds a legacy version of the datepicker that uses the legacy versions of components internally.
5eaf859
to
1c6a322
Compare
Closing in favor of #25648. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Switches the Material datepicker to be based on top of the MDC components.