Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): add aria descriptions for comparison range #25667

Closed

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Sep 20, 2022

Add aria descriptions to the calendar for the start and end of comparison range.

Fixes #23464

Screen Shot 2022-09-20 at 1 15 03 PM

Add aria descriptions to the calendar for the start and end of
comparison range.

Fixes angular#23464
@zarend zarend added Accessibility This issue is related to accessibility (a11y) target: minor This PR is targeted for the next minor release area: material/datepicker labels Sep 20, 2022
@zarend
Copy link
Contributor Author

zarend commented Sep 20, 2022

I thought about this and decided I don't like the API of it.

Developer should be able to configure the aria descriptions for the start and end of the comparison range, so that they can make sense in the context that the date-range picker is used. (This is similar problem we ran into with #25457

@zarend zarend closed this Sep 20, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) area: material/datepicker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(datepicker): Comparison dates are relying on single sensory characteristic
1 participant