Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/core): add option to disable core typography #25706

Merged
merged 1 commit into from Sep 27, 2022

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Sep 26, 2022

Adds an optional flag to the core mixin that can controls whether typography styles are emitted. This is planned to be a temporary addition before the v15 launch in order to migrate google3. Once all clients use this flag, it can be removed and the typography can be removed. For backwards compatibility, the ng update script will take care of external clients when they upgrade so that mat.core() will turn into mat.all-component-typographies(); mat.core().

@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Sep 26, 2022
src/material/core/_core.scss Outdated Show resolved Hide resolved
src/material/legacy-core/_core.scss Outdated Show resolved Hide resolved
@andrewseguin andrewseguin force-pushed the core-typography branch 2 times, most recently from 669cdc9 to dcabb28 Compare September 26, 2022 19:28
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Sep 26, 2022
@mmalerba mmalerba removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 26, 2022
@andrewseguin andrewseguin merged commit 73ef52c into angular:main Sep 27, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants