fix(cdk/a11y): clean up list key manager on destroy #25715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
force-pushed
the
25537/list-key-manager-destroy
branch
2 times, most recently
from
4c5a828
to
a6a77a4
Compare
Historically we haven't needed to do any cleanup for the `ListKeyManager`, because it didn't contain any rxjs subscriptions. Over time we've accumulated more functionality which now needs to be cleaned up. These changes introduce a `destroy` method and calls it in all the relevant places. I also removed any places where we previously had to do manual cleanup. Fixes angular#25537.
crisbeto
force-pushed
the
25537/list-key-manager-destroy
branch
from
a6a77a4
to
9e12c4a
Compare
crisbeto
requested review from
jelbourn,
devversion,
mmalerba and
andrewseguin
as code owners
mmalerba
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically we haven't needed to do any cleanup for the
ListKeyManager, because it didn't contain any rxjs subscriptions. Over time we've accumulated more functionality which now needs to be cleaned up.These changes introduce a
destroymethod and calls it in all the relevant places. I also removed any places where we previously had to do manual cleanup.Fixes #25537.