feat(material/core): remove typography styles from core mixin #25723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
the
target: major
mmalerba
approved these changes
Sep 28, 2022
src/material/core/_core.scss
Outdated
|
|
||
| // Mixin that renders all of the core styles that are not theme-dependent. | ||
| // TODO: Remove the `$exclude-typography` parameter once `ng update` automatically migrates | ||
| // client theme applications to manually include the typography mixin. | ||
| // TODO: Remove the `$exclude-typography` parameter after all internal clients migrated |
There was a problem hiding this comment.
remove all parameters right?
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All internal clients include typography in their theme files and this can be safely removed. This assumes the
ng updatescript will be updated to addmat.all-component-typographiesbefore allmat.corecalls.The parameter must remain until all cases internally no longer pass the param as an argument
BREAKING CHANGE:
core()mixin no longer provides typography styles. Applications must call componenttypographymixins to apply typography styles, or callthememixins with a theme config containing typography.