Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/chips): aria-selected not reflecting selection state #25742

Merged
merged 1 commit into from Oct 3, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 3, 2022

When the chip listbox is in single selection mode, it needs to remove aria-selected from the selected option and move it to the newly-selected one. The listbox was doing this already, but change detection wasn't being triggered which meant that the DOM was out of date.

When the chip listbox is in single selection mode, it needs to remove `aria-selected` from the selected option and move it to the newly-selected one. The listbox was doing this already, but change detection wasn't being triggered which meant that the DOM was out of date.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) target: major This PR is targeted for the next major release labels Oct 3, 2022
@crisbeto
Copy link
Member Author

crisbeto commented Oct 3, 2022

cc @zarend this might be related to #25736. I'm not completely sure since my repro steps were different from the ones you listed.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 3, 2022
@crisbeto crisbeto merged commit 17e217a into angular:main Oct 3, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants