fix(material/core): add typography hierarchy to prebuilt #25746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
the
target: major
crisbeto
reviewed
Oct 3, 2022
| @@ -23,3 +24,5 @@ $theme: theming.define-dark-theme(( | |||
|
|
|||
| // Include all theme styles for the components. | |||
| @include all-theme.all-legacy-component-themes($theme); | |||
|
|
|||
| @include typography.typography-hierarchy($theme); | |||
There was a problem hiding this comment.
We can land the changes as they are now, but for a follow-up PR: maybe we should bake this into the core-typography mixin?
There was a problem hiding this comment.
Yeah possibly - it seems weird to have to include this separately. I would have expected our theme files to be sufficient with an "all-component-themes" mixin.
crisbeto
approved these changes
Oct 3, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typography hierarchy back to the prebuilt themes.
They used to rely on
mat.corecallingall-component-typographies, which is equal toall-component-themes(with typography in the config) +typography-hierarchy.