Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/chips): don't remove aria-selected from deselected options #25748

Merged
merged 1 commit into from Oct 7, 2022
Merged

fix(material/chips): don't remove aria-selected from deselected options #25748

merged 1 commit into from Oct 7, 2022

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Oct 3, 2022

For chip-listbox, set aria-selected="false" on deselected options that are selectable. Conforms with WAI ARIA Listbox authoring practices guide, which says to always include aria-selected attribute on options that are selectable. Fix issue where voiceover reads every option as "selected" (#25736).

Fix #25736

@zarend zarend added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release area: material/chips labels Oct 3, 2022
@mmalerba
Copy link
Contributor

mmalerba commented Oct 4, 2022

I assume we'll want to apply the final behavior we land on for #25749 here as well, correct?

@zarend
Copy link
Contributor Author

zarend commented Oct 4, 2022

This PR can be landed independently of #25749, but I'm okay with merging them together when they're both ready if that's preferred.

Pretty much all that's left for me to do is to test this PR and #25749 again on screen readers, including chromeos

@zarend
fix(material/chips): don't remove aria-selected from deselected options
a2553c9 
For chip-listbox, set `aria-selected="false"` on deselected options that
are selectable. Conforms with [WAI ARIA Listbox authoring practices guide](
https://www.w3.org/WAI/ARIA/apg/patterns/listbox/), which says to always
include aria-selected attribute on options that are selectable. Fix issue where
voiceover reads every option as "selected" (angular#25736).

Fix angular#25736
@zarend
Copy link
Contributor Author

zarend commented Oct 4, 2022

I've finished testing this PR and it works on NVDA, VoiceOver and ChromeVox 👍

crisbeto
crisbeto approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 5, 2022
@zarend zarend added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Oct 7, 2022
@zarend zarend merged commit 147a354 into angular:main Oct 7, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/chips target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(material/chips): for single-select chips VoiceOver reads every option as selected
3 participants
@zarend @mmalerba @crisbeto