fix(material/chip): allow focusing to disabled listbox options #25771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still a draft, need to do more testing and cleanup the code a bit. |
zarend
added
P2
zarend
force-pushed
the
disabled-chip-option
branch
2 times, most recently
from
2f537cd
to
751ff55
Compare
Allow user to focus to disabled listbox options. Unlike other chips, disabled `MatChipOption` remains in the tab order, but it cannot be clicked. This aligns with WAI ARIA documented best practice to allow focusing disabled listbox options. Fix issue where screen reader does not announce disabled item in single selection list. Summary of API and behavior changes: - when disabled, `MatChipOption` sets `aria-disabled="true"` and omits `disabled` attribute. - Add private `@Input _alowFocusWithDisabled` to `MatChipAction` to support focusing the action when it is disabled. - `MatChipSet` defines `_skipPredicate` as an instance member which dervied classes may override. `_alowFocusWithDisabled` and `_skipPredicate` are internal API to the chips.
zarend
force-pushed
the
disabled-chip-option
branch
from
751ff55
to
ce420a8
Compare
zarend
requested review from
andrewseguin,
mmalerba and
crisbeto
as code owners
|
Hi @crisbeto , this is working now, and it's ready for your review |
zarend
added
target: rc
zarend
added a commit
that referenced
this pull request
Oct 13, 2022
Allow user to focus to disabled listbox options. Unlike other chips, disabled `MatChipOption` remains in the tab order, but it cannot be clicked. This aligns with WAI ARIA documented best practice to allow focusing disabled listbox options. Fix issue where screen reader does not announce disabled item in single selection list. Summary of API and behavior changes: - when disabled, `MatChipOption` sets `aria-disabled="true"` and omits `disabled` attribute. - Add private `@Input _alowFocusWithDisabled` to `MatChipAction` to support focusing the action when it is disabled. - `MatChipSet` defines `_skipPredicate` as an instance member which dervied classes may override. `_alowFocusWithDisabled` and `_skipPredicate` are internal API to the chips. (cherry picked from commit 3f68996)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow focusing to disabled listbox options