Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk/menu): add support for passing in data to the menu template #25778

Merged
merged 1 commit into from Oct 12, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 9, 2022

Adds the cdkMenuTriggerData and cdkContextMenuTriggerData inputs that allow the consumer of a CDK menu to pass context data to the menu template.

Fixes #25708.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Oct 9, 2022
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. One doc nit suggestion

src/cdk/menu/menu-trigger-base.ts Outdated Show resolved Hide resolved
@josephperrott josephperrott removed their request for review October 10, 2022 16:57
Adds the `cdkMenuTriggerData` and `cdkContextMenuTriggerData` inputs that allow the consumer of a CDK menu to pass context data to the menu template.

Fixes angular#25708.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 12, 2022
@angular-robot angular-robot bot added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Oct 12, 2022
@crisbeto crisbeto merged commit a2cf3f6 into angular:main Oct 12, 2022
@MichalK6677
Copy link

Is it possible to merge it into latest stable release v14?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(cdk/menu): Support passing additional context data like material/menu
3 participants