Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/core): default font family not picked up in define-typography-config #25789

Merged
merged 1 commit into from Oct 11, 2022
Merged

fix(material/core): default font family not picked up in define-typography-config #25789

merged 1 commit into from Oct 11, 2022

Commits on Oct 11, 2022

  1. fix(material/core): default font family not picked up in define-typog… 

    …raphy-config

The `define-typography-config` function was set up so that if a level doesn't have a `font-family`, it would pick up the one that was passed into the function. The problem is that after we switched the typography over to MDC, we started using the `typography-config-level-from-mdc` function which provides a default `font-family` which meant that the default passed into `define-typography-config` was being ignored.

These changes add some logic that allows us to take the default font family, if it is specified.

Fixes angular#25780.
    @crisbeto
    crisbeto committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    55c9f26 View commit details
    Browse the repository at this point in the history