Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): changed after checked error during overlapping open/close sequence #25843

Merged
merged 1 commit into from Oct 21, 2022
Merged

fix(material/datepicker): changed after checked error during overlapping open/close sequence #25843

merged 1 commit into from Oct 21, 2022

Conversation

crisbeto
Copy link
Member

Fixes that if the user triggers a closing sequence while the datepicker isn't finished opening, we end up triggering a "changed after checked" error.

Fixes #25837.

@crisbeto
fix(material/datepicker): changed after checked error during overlapp…
3ca13ac 
…ing open/close sequence

Fixes that if the user triggers a closing sequence while the datepicker isn't finished opening, we end up triggering a "changed after checked" error.

Fixes angular#25837.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Oct 21, 2022
jelbourn
jelbourn approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 21, 2022
@crisbeto crisbeto merged commit e694388 into angular:main Oct 21, 2022
crisbeto added a commit that referenced this pull request Oct 21, 2022
@crisbeto
fix(material/datepicker): changed after checked error during overlapp…
59b5d5e 
…ing open/close sequence (#25843)

Fixes that if the user triggers a closing sequence while the datepicker isn't finished opening, we end up triggering a "changed after checked" error.

Fixes #25837.

(cherry picked from commit e694388)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@zarend zarend zarend approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(datepicker): TouchUI causes ExpressionChangedAfterItHasBeenCheckedError on mat-form-field-should-float
3 participants
@crisbeto @jelbourn @zarend