fix(cdk/listbox): remove incorrect usage of validator #25856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the CDK listbox is providing itself as a validator so that it can validate that programmatically-assigned values are valid. This is incorrect, because validators are meant to check user-assigned values and the checks that are currently being performed can't happen purely through the UI. These changes remove the `Validator` implementation and replace the checks with runtime errors.
crisbeto
added
P3
crisbeto
requested review from
devversion,
josephperrott and
jelbourn
as code owners
devversion
approved these changes
Oct 24, 2022
crisbeto
added a commit
that referenced
this pull request
Oct 25, 2022
Currently the CDK listbox is providing itself as a validator so that it can validate that programmatically-assigned values are valid. This is incorrect, because validators are meant to check user-assigned values and the checks that are currently being performed can't happen purely through the UI. These changes remove the `Validator` implementation and replace the checks with runtime errors. (cherry picked from commit 3d5ad3f)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 29, 2022
In angular#25856 the check that verifies the validity of the form control value was moved into `writeValue`. This works as expected for assignments after initialization, but it throws an error incorrectly if there is a preselected value, because `writeValue` will be called before the options are available. These changes resolve the issue by checking that the options have been initialized before throwing the error.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 29, 2022
In angular#25856 the check that verifies the validity of the form control value was moved into `writeValue`. This works as expected for assignments after initialization, but it throws an error incorrectly if there is a preselected value, because `writeValue` will be called before the options are available. These changes resolve the issue by checking that the options have been initialized before throwing the error.
crisbeto
added a commit
that referenced
this pull request
Oct 29, 2022
In #25856 the check that verifies the validity of the form control value was moved into `writeValue`. This works as expected for assignments after initialization, but it throws an error incorrectly if there is a preselected value, because `writeValue` will be called before the options are available. These changes resolve the issue by checking that the options have been initialized before throwing the error.
crisbeto
added a commit
that referenced
this pull request
Oct 29, 2022
In #25856 the check that verifies the validity of the form control value was moved into `writeValue`. This works as expected for assignments after initialization, but it throws an error incorrectly if there is a preselected value, because `writeValue` will be called before the options are available. These changes resolve the issue by checking that the options have been initialized before throwing the error. (cherry picked from commit 166ed5e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CDK listbox is providing itself as a validator so that it can validate that programmatically-assigned values are valid. This is incorrect, because validators are meant to check user-assigned values and the checks that are currently being performed can't happen purely through the UI.
These changes remove the
Validatorimplementation and replace the checks with runtime errors.