Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/chips): show checkmark for selected non-selectable chips #25942

Merged
merged 1 commit into from Nov 9, 2022
Merged

fix(material/chips): show checkmark for selected non-selectable chips #25942

merged 1 commit into from Nov 9, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 8, 2022

Fixes that chips that were selected programmatically, but were set as selectable="false" weren't showing the checkmark as intended in #25890. Also removes some of the logic now that we can assume that the checkmark will always be present.

@crisbeto
fix(material/chips): show checkmark for selected non-selectable chips
b840d84 
Fixes that chips that were selected programmatically, but were set as `selectable="false"` weren't showing the checkmark as intended in angular#25890. Also removes some of the logic now that we can assume that the checkmark will always be present.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Nov 8, 2022
@crisbeto crisbeto mentioned this pull request Nov 8, 2022
Closed
1 task
mmalerba
mmalerba approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zarend
zarend approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zarend
Copy link
Contributor

zarend commented Nov 9, 2022

good fix, didn't know about this edge case

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 9, 2022
@crisbeto crisbeto self-assigned this Nov 9, 2022
@crisbeto crisbeto merged commit 871f8f2 into angular:main Nov 9, 2022
crisbeto added a commit that referenced this pull request Nov 9, 2022
@crisbeto
fix(material/chips): show checkmark for selected non-selectable chips (…
0f52389 
…#25942)

Fixes that chips that were selected programmatically, but were set as `selectable="false"` weren't showing the checkmark as intended in #25890. Also removes some of the logic now that we can assume that the checkmark will always be present.

(cherry picked from commit 871f8f2)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zarend zarend zarend approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crisbeto @zarend @mmalerba